Enable -Wsuggest-override
authorTom Tromey <tom@tromey.com>
Fri, 27 Apr 2018 04:46:54 +0000 (22:46 -0600)
committerTom Tromey <tom@tromey.com>
Fri, 27 Apr 2018 18:53:14 +0000 (12:53 -0600)
commit632e107b32c0fe8aede62e070b00756e9fdd2c01
tree33106f00d62048ea028bdad94f0df1c21a463f3b
parent197b262f98ff01516921b3d3056d86a9577535be
Enable -Wsuggest-override

I noticed the existence of -Wsuggest-override and so this patch
enables it for gdb.  It found a few spots that could use "override".
Also I went ahead and removed all uses of the "OVERRIDE" macro.

Using override is beneficial because it makes it harder to change a
base class and then forget to change a derived class.

Tested by the buildbot.

ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

* configure: Rebuild.
* warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
* dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
"OVERRIDE".
(class symbol_needs_eval_context): Likewise.
* dwarf2read.c (mock_mapped_index::symbol_name_count)
(mock_mapped_index::symbol_name_at): Use "override".  Remove
"virtual".
* dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
"override".
(class dwarf_expr_executor): Use "override", not "OVERRIDE".
* aarch64-tdep.c (instruction_reader::read): Use "override".
(instruction_reader_test::read): Likewise.
* arm-tdep.c (instruction_reader::read): Use "override".
(instruction_reader_thumb::read): Likewise.

gdbserver/ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

* configure: Rebuild.
gdb/ChangeLog
gdb/aarch64-tdep.c
gdb/arm-tdep.c
gdb/configure
gdb/dwarf2-frame.c
gdb/dwarf2loc.c
gdb/dwarf2read.c
gdb/gdbserver/ChangeLog
gdb/gdbserver/configure
gdb/warning.m4