TTY: call tty_driver_lookup_tty unconditionally
authorJiri Slaby <jslaby@suse.cz>
Wed, 12 Oct 2011 09:32:45 +0000 (11:32 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 18 Oct 2011 23:39:44 +0000 (16:39 -0700)
commit631180aca723cb92e128fdac5fd144e913ca84e5
treeeaf96c5d9c0c93ff6459a85110d62bd771c29eaf
parent1177c0efc04d032644895b8d757f55b433912596
TTY: call tty_driver_lookup_tty unconditionally

Commit 4a2b5fddd5 (Move tty lookup/reopen to caller) made the call to
tty_driver_lookup_tty conditional in tty_open. It doesn't look like it
was an intention. Or if it was, it was not documented in the changelog
and the code now looks weird. For example there would be no need to
remember the tty driver and tty index. Further the condition depends
on a tty which we drop a reference of already.

If I'm looking correctly, this should not matter thanks to the locking
currently done there. Thus, tty_driver->ttys[idx] cannot change under
our hands. But anyway, it makes sense to change that to the old
behaviour.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: stable <stable@vger.kernel.org>
Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Cc: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/tty_io.c