net/smc: Fix possible leaked pernet namespace in smc_init()
authorChen Zhongjin <chenzhongjin@huawei.com>
Tue, 1 Nov 2022 09:37:22 +0000 (17:37 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Nov 2022 03:42:09 +0000 (20:42 -0700)
commit62ff373da2534534c55debe6c724c7fe14adb97f
tree2ffec044f3b984197b80af81cfaca4c67ff2aca3
parent2ae34111fe4eebb69986f6490015b57c88804373
net/smc: Fix possible leaked pernet namespace in smc_init()

In smc_init(), register_pernet_subsys(&smc_net_stat_ops) is called
without any error handling.
If it fails, registering of &smc_net_ops won't be reverted.
And if smc_nl_init() fails, &smc_net_stat_ops itself won't be reverted.

This leaves wild ops in subsystem linkedlist and when another module
tries to call register_pernet_operations() it triggers page fault:

BUG: unable to handle page fault for address: fffffbfff81b964c
RIP: 0010:register_pernet_operations+0x1b9/0x5f0
Call Trace:
  <TASK>
  register_pernet_subsys+0x29/0x40
  ebtables_init+0x58/0x1000 [ebtables]
  ...

Fixes: 194730a9beb5 ("net/smc: Make SMC statistics network namespace aware")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Link: https://lore.kernel.org/r/20221101093722.127223-1-chenzhongjin@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/smc/af_smc.c