powerpc/signal32: Use struct_group() to zero spe regs
authorKees Cook <keescook@chromium.org>
Thu, 18 Nov 2021 20:36:04 +0000 (12:36 -0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 1 Dec 2021 23:39:00 +0000 (10:39 +1100)
commit62ea67e31981bca95ec16c37e2a1fba68f3dd8c5
tree48bd43cd095317cd076eaa4f542289cfbb6f60d6
parentaf11dee4361b3519981fa04d014873f9d9edd6ac
powerpc/signal32: Use struct_group() to zero spe regs

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memset(), avoid intentionally writing across
neighboring fields.

Add a struct_group() for the spe registers so that memset() can correctly reason
about the size:

   In function 'fortify_memset_chk',
       inlined from 'restore_user_regs.part.0' at arch/powerpc/kernel/signal_32.c:539:3:
   >> include/linux/fortify-string.h:195:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
     195 |    __write_overflow_field();
         |    ^~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211118203604.1288379-1-keescook@chromium.org
arch/powerpc/include/asm/processor.h
arch/powerpc/kernel/signal_32.c