wireless: carl9170: fix clang build warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 25 Mar 2019 12:43:44 +0000 (13:43 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 29 Apr 2019 15:00:42 +0000 (18:00 +0300)
commit62acdcfa8b7ae921b70afff888e994df117022a6
tree1ddc47cee0aec9062ce9fad37a5792634cb25ca5
parentbfabdd6997323adbedccb13a3fed1967fb8cf8f5
wireless: carl9170: fix clang build warning

clang fails to eliminate some dead code with always-taken branches
when CONFIG_PROFILE_ANNOTATED_BRANCHES is set, leading to a false-positive
warning:

drivers/net/wireless/ath/carl9170/mac.c:522:3: error: variable 'power' is used uninitialized whenever 'if' condition is
      false [-Werror,-Wsometimes-uninitialized]
                BUG_ON(1);
                ^~~~~~~~~

Change both instances of BUG_ON(1) in carl9170 to the simpler BUG()
to avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/carl9170/mac.c
drivers/net/wireless/ath/carl9170/rx.c