selinux: Refactor to remove bprm_secureexec hook
authorKees Cook <keescook@chromium.org>
Tue, 18 Jul 2017 22:25:25 +0000 (15:25 -0700)
committerKees Cook <keescook@chromium.org>
Tue, 1 Aug 2017 19:03:07 +0000 (12:03 -0700)
commit62874c3adf709b884ceb0c61c35ab3794b3b0e95
tree2fab65d2a21b0c898063d1accaa59bc10793e647
parent993b3ab0642e57da5de6bef11dd50db7e2fc3b7e
selinux: Refactor to remove bprm_secureexec hook

The SELinux bprm_secureexec hook can be merged with the bprm_set_creds
hook since it's dealing with the same information, and all of the details
are finalized during the first call to the bprm_set_creds hook via
prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
via bprm->called_set_creds).

Here, the test can just happen at the end of the bprm_set_creds hook,
and the bprm_secureexec hook can be dropped.

Cc: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Paul Moore <paul@paul-moore.com>
Tested-by: Paul Moore <paul@paul-moore.com>
Acked-by: Serge Hallyn <serge@hallyn.com>
Reviewed-by: James Morris <james.l.morris@oracle.com>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
security/selinux/hooks.c