Input: ps2-gpio - remove tx timeout from ps2_gpio_irq_tx()
authorDanilo Krummrich <danilokrummrich@dk-develop.de>
Tue, 15 Feb 2022 22:44:26 +0000 (14:44 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 16 Feb 2022 01:25:38 +0000 (17:25 -0800)
commit6283cc9e7785e3df6160dbce4940b3a5925cb728
tree2d6496785780487aac32f1c0fad10710b9365101
parent2fa9c57af062ded71e68462264d315a547c72da2
Input: ps2-gpio - remove tx timeout from ps2_gpio_irq_tx()

Actually, there's no extra clock pulse to wait for.

The assumption of an extra clock pulse was mistakenly derived from the
fact that by the time this driver was introduced the GPIO controller of
the test machine (bcm2835) generated spurious interrupts.

Since now spurious interrupts are handled properly this can and must be
removed in order to make TX xfers work properly.

While at it, remove duplicate gpiod_direction_input(). The data gpio
must already be configured to act as input when receiving the ACK bit.

This patch is tested with the original hardware (peripherals and board)
the driver was developed on.

Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
Link: https://lore.kernel.org/r/20220215160208.34826-4-danilokrummrich@dk-develop.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/ps2-gpio.c