net: add per-cpu storage and net->core_stats
authorEric Dumazet <edumazet@google.com>
Fri, 11 Mar 2022 05:14:20 +0000 (21:14 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 12 Mar 2022 07:17:24 +0000 (23:17 -0800)
commit625788b5844511cf4c30cffa7fa0bc3a69cebc82
tree1b1b091212352474f56d6c4497017bc206c7c785
parenta8c063372bff46ed8f94c87cfac45a3ce016a380
net: add per-cpu storage and net->core_stats

Before adding yet another possibly contended atomic_long_t,
it is time to add per-cpu storage for existing ones:
 dev->tx_dropped, dev->rx_dropped, and dev->rx_nohandler

Because many devices do not have to increment such counters,
allocate the per-cpu storage on demand, so that dev_get_stats()
does not have to spend considerable time folding zero counters.

Note that some drivers have abused these counters which
were supposed to be only used by core networking stack.

v4: should use per_cpu_ptr() in dev_get_stats() (Jakub)
v3: added a READ_ONCE() in netdev_core_stats_alloc() (Paolo)
v2: add a missing include (reported by kernel test robot <lkp@intel.com>)
    Change in netdev_core_stats_alloc() (Jakub)

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: jeffreyji <jeffreyji@google.com>
Reviewed-by: Brian Vazquez <brianvv@google.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/20220311051420.2608812-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
15 files changed:
drivers/net/bonding/bond_main.c
drivers/net/ethernet/broadcom/bnxt/bnxt.c
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
drivers/net/ipvlan/ipvlan_core.c
drivers/net/macvlan.c
drivers/net/net_failover.c
drivers/net/tun.c
drivers/net/vxlan/vxlan_core.c
include/linux/netdevice.h
include/net/bonding.h
net/core/dev.c
net/core/gro_cells.c
net/hsr/hsr_device.c
net/xfrm/xfrm_device.c