selinux: fix bad cleanup on error in hashtab_duplicate()
authorOndrej Mosnacek <omosnace@redhat.com>
Tue, 17 May 2022 12:08:16 +0000 (14:08 +0200)
committerPaul Moore <paul@paul-moore.com>
Tue, 17 May 2022 22:34:35 +0000 (18:34 -0400)
commit6254bd3db316c9ccb3b05caa8b438be63245466f
treeccbc625604a64e01eafc773a0c3fa7f66df6e14a
parent42226c989789d8da4af1de0c31070c96726d990c
selinux: fix bad cleanup on error in hashtab_duplicate()

The code attempts to free the 'new' pointer using kmem_cache_free(),
which is wrong because this function isn't responsible of freeing it.
Instead, the function should free new->htable and clear the contents of
*new (to prevent double-free).

Cc: stable@vger.kernel.org
Fixes: c7c556f1e81b ("selinux: refactor changing booleans")
Reported-by: Wander Lairson Costa <wander@redhat.com>
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ss/hashtab.c