ld testsuite use of notarget
authorAlan Modra <amodra@gmail.com>
Tue, 10 Jul 2018 13:43:10 +0000 (23:13 +0930)
committerAlan Modra <amodra@gmail.com>
Tue, 10 Jul 2018 14:28:29 +0000 (23:58 +0930)
commit624940689a97573ed1e24ae054dcb2fd6906f557
treed2a1b7d952b229e307d18eaebe01f35dfb8a0c29
parent3541979fff2861c9537f299e31ac17a436bf1228
ld testsuite use of notarget

Much of the time it is better to use xfail rather than notarget to
hide a testsuite failure no one is planning on fixing.

1) When a target is fixed, an inappropriate xfail results in XPASS
   whereas notarget is silent.  Leaving in an inappropriate notarget
   entry risks the bug reappearing later, silently.
2) Tests might be used as a template for a new test, carrying over
   notarget and/or xfail.  Inappropriate notarget entries are silent.
3) An xfailed test that mysteriously XPASSes might actually indicate a
   bug.

* testsuite/ld-elf/attributes.d: Use xfail rather than notarget.
* testsuite/ld-elf/hash.d: Likewise.
* testsuite/ld-elf/orphan-10.d: Likewise.
* testsuite/ld-elf/overlay.d: Likewise.
* testsuite/ld-elf/pr14926.d: Likewise.
* testsuite/ld-elf/pr17550d.d: Likewise.
* testsuite/ld-elf/pr19539.d: Likewise.
* testsuite/ld-elf/pr22319.d: Likewise.
* testsuite/ld-misc/defsym1.d: Likewise.
* testsuite/ld-pe/pr19803.d: Likewise.
* testsuite/ld-scripts/assign-loc.d: Likewise.
* testsuite/ld-scripts/defined4.d: Likewise.
* testsuite/ld-scripts/empty-address-1.d: Likewise.
* testsuite/ld-scripts/empty-address-2a.d: Likewise.
* testsuite/ld-scripts/empty-address-2b.d: Likewise.
* testsuite/ld-scripts/fill.d: Likewise.
* testsuite/ld-scripts/fill16.d: Likewise.
* testsuite/ld-scripts/pr14962.d: Likewise.
* testsuite/ld-scripts/pr14962-2.d: Likewise.
* testsuite/ld-unique/pr21529.d: Likewise.
* testsuite/ld-elf/compress1a.d: Likewise, and adjust targets.
* testsuite/ld-elf/compressed1a.d: Likewise.
* testsuite/ld-elf/compressed1d.d: Likewise.
* testsuite/ld-elf/compressed1e.d: Likewise.
* testsuite/ld-elf/eh5.d: Likewise.
* testsuite/ld-elf/group8a.d: Likewise.
* testsuite/ld-elf/linkonce2.d: Likewise.
* testsuite/ld-elf/orphan-9.d: Likewise.
* testsuite/ld-elf/pr17550a.d: Likewise.
* testsuite/ld-elf/pr17550b.d: Likewise.
* testsuite/ld-elf/pr17550c.d: Likewise.
* testsuite/ld-elf/pr19162.d: Likewise.
* testsuite/ld-elf/pr21884.d: Likewise.
* testsuite/ld-gc/pr19167.d: Likewise.
* testsuite/ld-gc/pr20022.d: Likewise.
* testsuite/ld-gc/start.d: Likewise.
* testsuite/ld-elf/orphan-11.d: Delete notarget.
* testsuite/ld-elf/orphan-12.d: Likewise.
* testsuite/ld-gc/stop.d: Likewise.
* testsuite/ld-scripts/empty-address-3a.d: Likewise.
* testsuite/ld-scripts/empty-address-3b.d: Likewise.
* testsuite/ld-ifunc/pr17154-x86-64-now.d: Delete duplicate notarget.
* testsuite/ld-scripts/section-match-1.d: Comment fix.
44 files changed:
ld/ChangeLog
ld/testsuite/ld-elf/attributes.d
ld/testsuite/ld-elf/compress1a.d
ld/testsuite/ld-elf/compressed1a.d
ld/testsuite/ld-elf/compressed1d.d
ld/testsuite/ld-elf/compressed1e.d
ld/testsuite/ld-elf/eh5.d
ld/testsuite/ld-elf/group8a.d
ld/testsuite/ld-elf/hash.d
ld/testsuite/ld-elf/linkonce2.d
ld/testsuite/ld-elf/orphan-10.d
ld/testsuite/ld-elf/orphan-11.d
ld/testsuite/ld-elf/orphan-12.d
ld/testsuite/ld-elf/orphan-9.d
ld/testsuite/ld-elf/overlay.d
ld/testsuite/ld-elf/pr14926.d
ld/testsuite/ld-elf/pr17550a.d
ld/testsuite/ld-elf/pr17550b.d
ld/testsuite/ld-elf/pr17550c.d
ld/testsuite/ld-elf/pr17550d.d
ld/testsuite/ld-elf/pr19162.d
ld/testsuite/ld-elf/pr19539.d
ld/testsuite/ld-elf/pr21884.d
ld/testsuite/ld-elf/pr22319.d
ld/testsuite/ld-gc/pr19167.d
ld/testsuite/ld-gc/pr20022.d
ld/testsuite/ld-gc/start.d
ld/testsuite/ld-gc/stop.d
ld/testsuite/ld-ifunc/pr17154-x86-64-now.d
ld/testsuite/ld-misc/defsym1.d
ld/testsuite/ld-pe/pr19803.d
ld/testsuite/ld-scripts/assign-loc.d
ld/testsuite/ld-scripts/defined4.d
ld/testsuite/ld-scripts/empty-address-1.d
ld/testsuite/ld-scripts/empty-address-2a.d
ld/testsuite/ld-scripts/empty-address-2b.d
ld/testsuite/ld-scripts/empty-address-3a.d
ld/testsuite/ld-scripts/empty-address-3b.d
ld/testsuite/ld-scripts/fill.d
ld/testsuite/ld-scripts/fill16.d
ld/testsuite/ld-scripts/pr14962-2.d
ld/testsuite/ld-scripts/pr14962.d
ld/testsuite/ld-scripts/section-match-1.d
ld/testsuite/ld-unique/pr21529.d