[lldb] Don't emit artificial constructor declarations as global functions
authorRaphael Isemann <teemperor@gmail.com>
Thu, 17 Oct 2019 18:16:50 +0000 (18:16 +0000)
committerRaphael Isemann <teemperor@gmail.com>
Thu, 17 Oct 2019 18:16:50 +0000 (18:16 +0000)
commit6237c9fe6ce966ce366005a55df8c267ea32a064
treed702956f0d3d59cb14b104c66c6bb5fcbdd23282
parent5be7eb3ab4da6e89ed23b137e6baaa13a530c9b3
[lldb] Don't emit artificial constructor declarations as global functions

Summary:
When we have a artificial constructor DIE, we currently create from that a global function with the name of that class.
That ends up causing a bunch of funny errors such as "must use 'struct' tag to refer to type 'Foo' in this scope" when
doing `Foo f`. Also causes that constructing a class via `Foo()` actually just calls that global function.

The fix is that when we have an artificial method decl, we always treat it as handled even if we don't create a CXXMethodDecl
for it (which we never do for artificial methods at the moment).

Fixes rdar://55757491 and probably some other radars.

Reviewers: aprantl, vsk, shafik

Reviewed By: aprantl

Subscribers: jingham, shafik, labath, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68130

llvm-svn: 375151
lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/main.cpp
lldb/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py [new file with mode: 0644]
lldb/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/main.cpp [new file with mode: 0644]
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp