drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning
authorAshutosh Dixit <ashutosh.dixit@intel.com>
Fri, 12 May 2023 20:37:35 +0000 (13:37 -0700)
committerAndi Shyti <andi.shyti@linux.intel.com>
Mon, 15 May 2023 09:41:14 +0000 (11:41 +0200)
commit621b6783c73100067c844c3be0b254c2f350e8ec
tree0c3d1ff2024758f4a9a478713b960fb034d013c4
parent8ba3ba992fc2e456f4211ac4dc80dcb7775e722f
drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL)
causes the following warning:

  UBSAN: invalid-load in drivers/gpu/drm/i915/gt/uc/intel_uc.c:558:2
  load of value 255 is not a valid value for type '_Bool'
  Call Trace:
   dump_stack_lvl+0x57/0x7d
   ubsan_epilogue+0x5/0x40
   __ubsan_handle_load_invalid_value.cold+0x43/0x48
   __uc_init_hw+0x76a/0x903 [i915]
   ...
   i915_driver_probe+0xfb1/0x1eb0 [i915]
   i915_pci_probe+0xbe/0x2d0 [i915]

The warning happens because during probe i915_hwmon is still not available
which results in the output boolean variable *old remaining
uninitialized. Silence the warning by initializing the variable to an
arbitrary value.

v2: Move variable initialization to the declaration (Andi)

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230512203735.2635237-1-ashutosh.dixit@intel.com
drivers/gpu/drm/i915/gt/uc/intel_uc.c