HID: hid-uclogic-params: Invalid parameter check in uclogic_params_init
authorJosé Expósito <jose.exposito89@gmail.com>
Wed, 5 Jan 2022 17:29:12 +0000 (18:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:54 +0000 (11:03 +0100)
commit621aade97324398e74e8cd921fc02fc015e1d606
treee9ec6725d72b99715d5b6f1f5e214ede04b9889f
parent78e8660e9d909702d5d17660c46360bcd57e80ba
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_init

[ Upstream commit f364c571a5c77e96de2d32062ff019d6b8d2e2bc ]

The function performs a check on its input parameters, however, the
hdev parameter is used before the check.

Initialize the stack variables after checking the input parameters to
avoid a possible NULL pointer dereference.

Fixes: 9614219e9310e ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443831 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-uclogic-params.c