[ThinLTO] Always emit a summary when compiling in ThinLTO mode
authorTeresa Johnson <tejohnson@google.com>
Tue, 20 Sep 2016 23:07:17 +0000 (23:07 +0000)
committerTeresa Johnson <tejohnson@google.com>
Tue, 20 Sep 2016 23:07:17 +0000 (23:07 +0000)
commit620c140a9b50b715296f2e1412834aac151bb440
treeb511c96b0827282672ce5d3bc2ceb395cd20579a
parent92d1960e3b63c4c9ca7e7af3463b39c46864c792
[ThinLTO] Always emit a summary when compiling in ThinLTO mode

Summary:
Emit an empty summary section, instead of no summary section, when
there are no global variables in the index. This ensures that LTO
will treat these files as ThinLTO inputs, instead of as regular
LTO inputs.

In addition to not being what the user likely intended when
compiling with -flto=thin, the current behavior is problematic for
distributed build systems that expect to get ThinLTO index and imports
files back for each input compiled with -flto=thin. Combining into
a single regular LTO module also reduces the backend parallelism.
And in the case where the index was suppressed due to uses in
inline assembly, combining into a single LTO module could provoke
renaming of duplicates that we were trying to prevent by suppressing
the index.

This change required a couple of fixes to handle the empty summary
section.

Reviewers: mehdi_amini

Subscribers: mehdi_amini, llvm-commits, pcc

Differential Revision: https://reviews.llvm.org/D24779

llvm-svn: 282037
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
llvm/lib/LTO/LTO.cpp
llvm/test/Bitcode/thinlto-empty-summary-section.ll [new file with mode: 0644]
llvm/test/ThinLTO/X86/Inputs/emit_imports.ll
llvm/test/ThinLTO/X86/Inputs/empty.ll [new file with mode: 0644]
llvm/test/ThinLTO/X86/emit_imports.ll
llvm/test/tools/gold/X86/Inputs/thinlto_empty.ll [new file with mode: 0644]
llvm/test/tools/gold/X86/thinlto_emit_imports.ll