bpf: Initialize storage pointers to NULL to prevent freeing garbage pointer
authorAndrii Nakryiko <andriin@fb.com>
Mon, 9 Mar 2020 22:27:55 +0000 (15:27 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 10 Mar 2020 02:56:48 +0000 (19:56 -0700)
commit62039c30c19dcab96621e074aeeb90da7100def7
tree7eaf14dc8ca1e1c1751eb54448f63f7ad35bc002
parent93e5fbb18cec70b3b5c614f67b65388829113bdd
bpf: Initialize storage pointers to NULL to prevent freeing garbage pointer

Local storage array isn't initialized, so if cgroup storage allocation fails
for BPF_CGROUP_STORAGE_SHARED, error handling code will attempt to free
uninitialized pointer for BPF_CGROUP_STORAGE_PERCPU storage type. Avoid this
by always initializing storage pointers to NULLs.

Fixes: 8bad74f9840f ("bpf: extend cgroup bpf core to allow multiple cgroup storage types")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200309222756.1018737-1-andriin@fb.com
kernel/bpf/cgroup.c