iavf: fix err handling for MAC replace
authorPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Mon, 19 Jun 2023 08:06:35 +0000 (04:06 -0400)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 22 Jun 2023 16:12:26 +0000 (09:12 -0700)
commit61f723e6f3d20f3276c678cd346de5ea86b8e5d3
treeefa96822413ee7048f73a751e00cac60283c525a
parent98e95872f2b818c74872d073eaa4c937579d41fc
iavf: fix err handling for MAC replace

Defer removal of current primary MAC until a replacement is successfully
added. Previous implementation would left filter list with no primary MAC.
This was found while reading the code.

The patch takes advantage of the fact that there can only be a single primary
MAC filter at any time ([1] by Piotr)

Piotr has also applied some review suggestions during our internal patch
submittal process.

[1] https://lore.kernel.org/netdev/20230614145302.902301-2-piotrx.gardocki@intel.com/

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_main.c