powerpc: Fix __clear_user() with KUAP enabled
authorAndrew Donnellan <ajd@linux.ibm.com>
Mon, 9 Dec 2019 13:22:21 +0000 (00:22 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 16 Dec 2019 12:19:44 +0000 (23:19 +1100)
commit61e3acd8c693a14fc69b824cb5b08d02cb90a6e7
treebdc47c5f24399173d911615fb312fd0be8fa4a53
parente352f576d345e5bf1fb62c8559851448a6c1d9cd
powerpc: Fix __clear_user() with KUAP enabled

The KUAP implementation adds calls in clear_user() to enable and
disable access to userspace memory. However, it doesn't add these to
__clear_user(), which is used in the ptrace regset code.

As there's only one direct user of __clear_user() (the regset code),
and the time taken to set the AMR for KUAP purposes is going to
dominate the cost of a quick access_ok(), there's not much point
having a separate path.

Rename __clear_user() to __arch_clear_user(), and make __clear_user()
just call clear_user().

Reported-by: syzbot+f25ecf4b2982d8c7a640@syzkaller-ppc64.appspotmail.com
Reported-by: Daniel Axtens <dja@axtens.net>
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Fixes: de78a9c42a79 ("powerpc: Add a framework for Kernel Userspace Access Protection")
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
[mpe: Use __arch_clear_user() for the asm version like arm64 & nds32]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191209132221.15328-1-ajd@linux.ibm.com
arch/powerpc/include/asm/uaccess.h
arch/powerpc/lib/string_32.S
arch/powerpc/lib/string_64.S