ipv4: Handle attempt to delete multipath route when fib_info contains an nh reference
authorDavid Ahern <dsahern@kernel.org>
Thu, 6 Oct 2022 16:48:49 +0000 (10:48 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Oct 2022 07:47:08 +0000 (08:47 +0100)
commit61b91eb33a69c3be11b259c5ea484505cd79f883
tree0054b0a1791dac5fa933e54298a74d6b97047452
parent3030cbff67a7ae12b4b7bf69a605699372424f41
ipv4: Handle attempt to delete multipath route when fib_info contains an nh reference

Gwangun Jung reported a slab-out-of-bounds access in fib_nh_match:
    fib_nh_match+0xf98/0x1130 linux-6.0-rc7/net/ipv4/fib_semantics.c:961
    fib_table_delete+0x5f3/0xa40 linux-6.0-rc7/net/ipv4/fib_trie.c:1753
    inet_rtm_delroute+0x2b3/0x380 linux-6.0-rc7/net/ipv4/fib_frontend.c:874

Separate nexthop objects are mutually exclusive with the legacy
multipath spec. Fix fib_nh_match to return if the config for the
to be deleted route contains a multipath spec while the fib_info
is using a nexthop object.

Fixes: 493ced1ac47c ("ipv4: Allow routes to use nexthop objects")
Fixes: 6bf92d70e690 ("net: ipv4: fix route with nexthop object delete warning")
Reported-by: Gwangun Jung <exsociety@gmail.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_semantics.c
tools/testing/selftests/net/fib_nexthops.sh