[SCSI] fcoe: Allocate fcoe_ctlr with fcoe_interface, not as a member
authorRobert Love <robert.w.love@intel.com>
Wed, 23 May 2012 02:06:10 +0000 (19:06 -0700)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 23 May 2012 08:36:27 +0000 (09:36 +0100)
commit619fe4bed415e5d8a4749937f42b6a8a9031d4aa
tree8b52f6fd4b2ba58ef898f628aba8ab49111e1aa8
parentb7e94a1686c5daef4f649f7f4f839cc294f07710
[SCSI] fcoe: Allocate fcoe_ctlr with fcoe_interface, not as a member

Currently the fcoe_ctlr associated with an interface is allocated
as a member of struct fcoe_interface. This causes problems when
attempting to use the new fcoe_sysfs APIs which allow us to allocate
the fcoe_interface as private data to the fcoe_ctlr_device instance.
The problem is that libfcoe wants to be able use pointer math to find a
fcoe_ctlr's fcoe_ctlr_device as well as finding a fcoe_ctlr_device's
assocated fcoe_ctlr. To do this we need to allocate the
fcoe_ctlr_device, with private data for the LLD. The private data
contains the fcoe_ctlr and its private data is the fcoe_interface.
This patch only allocates the fcoe_interface with the fcoe_ctlr, the
fcoe_ctlr_device will be added in a later patch, which will complete
the below diagram-

+------------------+
| fcoe_ctlr_device |
+------------------+
| fcoe_ctlr        |
+------------------+
| fcoe_interface   |
+------------------+

This prep work will allow us to go from a fcoe_ctlr_device instance
to its fcoe_ctlr as well as from a fcoe_ctlr to its fcoe_ctlr_device
once the fcoe_sysfs API is in use (later patches in this series).

Signed-off-by: Robert Love <robert.w.love@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/fcoe/fcoe.c
drivers/scsi/fcoe/fcoe.h
include/scsi/libfcoe.h