Move decl completion out of the ASTImporterDelegate and document it [NFC]
authorRaphael Isemann <teemperor@gmail.com>
Fri, 20 Sep 2019 12:52:55 +0000 (12:52 +0000)
committerRaphael Isemann <teemperor@gmail.com>
Fri, 20 Sep 2019 12:52:55 +0000 (12:52 +0000)
commit6192ad262239934df111ca5297dcc48bec597a22
tree31b43fe1642086f5d61e35f3cc1b4bfad12d0525
parent169cb63478aa047451786d8ccf6af4b721e3b271
Move decl completion out of the ASTImporterDelegate and document it [NFC]

Summary:
The ASTImporterDelegate is currently responsible for both recording and also completing
types. This patch moves the actual completion and recording code outside the ASTImporterDelegate
to reduce the amount of responsibilities the ASTImporterDelegate has to fulfill.

As I anyway had to touch the code when moving I also documented and refactored most of it
(e.g. no more asserts that we call the deporting start/end function always as a pair).

Note that I had to make the ASTImporterDelegate and it's related functions public now so that
I can move out the functionality in another class (that doesn't need to be in the header).

Reviewers: shafik, aprantl, martong, a.sidorin

Reviewed By: martong

Subscribers: rnkovacs, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D61478

llvm-svn: 372385
lldb/include/lldb/Symbol/ClangASTImporter.h
lldb/source/Symbol/ClangASTImporter.cpp