rt2x00: fix rfkill regression on rt2500pci
authorStanislaw Gruszka <stf_xl@wp.pl>
Mon, 16 Jun 2014 16:45:15 +0000 (18:45 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 17 Jun 2014 18:11:16 +0000 (14:11 -0400)
commit616a8394b5df8c88f4dd416f4527439a4e365034
tree43c9bc8d5e6ff17e208bd2513e545645eeb57fdf
parent2fc68eb122c7ea6cd5be1fe7d6650c0beb2f4f40
rt2x00: fix rfkill regression on rt2500pci

As reported by Niels, starting rfkill polling during device probe
(commit e2bc7c5, generally sane change) broke rfkill on rt2500pci
device. I considered that bug as some initalization issue, which
should be fixed on rt2500pci specific code. But after several
attempts (see bug report for details) we fail to find working solution.
Hence I decided to revert to old behaviour on rt2500pci to fix
regression.

Additionally patch also unregister rfkill on device remove instead
of ifconfig down, what was another issue introduced by bad commit.

Bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=73821

Fixes: e2bc7c5f3cb8 ("rt2x00: Fix rfkill_polling register function.")
Cc: stable@vger.kernel.org
Bisected-by: Niels <nille0386@googlemail.com>
Reported-and-tested-by: Niels <nille0386@googlemail.com>
Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2500pci.c
drivers/net/wireless/rt2x00/rt2x00.h
drivers/net/wireless/rt2x00/rt2x00dev.c