Bug 679808 - e_source_selector_set_primary_selection() has side-effects
authorMatthew Barnes <mbarnes@redhat.com>
Sun, 5 Aug 2012 19:56:18 +0000 (15:56 -0400)
committerMatthew Barnes <mbarnes@redhat.com>
Sun, 5 Aug 2012 20:07:37 +0000 (16:07 -0400)
commit6143c9a743be36f304e0f3503ae2de96be77065b
tree497913d0d9d87db0c4ae013dcb586d16e92a170b
parent39446c047149cd5fdf2390d019e38b71ea60417d
Bug 679808 - e_source_selector_set_primary_selection() has side-effects

In ESourceSelector parlance, the "primary selection" is the highlighted
tree view item.  A tree view item is "selected" if the check box cell is
ticked.  The two selection states are supposed to be orthogonal.

e_source_selector_set_primary_selection() has apparently for some time
been highlighting the requested item and also activating its check box.
That last part is an unwanted and undocumented side-effect.

This commit removes the side-effect and explicitly states in the API
documentation that the function does NOT alter the item's check box.
libedataserverui/e-source-selector.c