[Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assign...
authorRoman Lebedev <lebedev.ri@gmail.com>
Sat, 7 Apr 2018 10:39:21 +0000 (10:39 +0000)
committerRoman Lebedev <lebedev.ri@gmail.com>
Sat, 7 Apr 2018 10:39:21 +0000 (10:39 +0000)
commit61061d69eacfb546283f33cba053c29bb1c1ef7e
tree671a06ad0b749490526e6b057db7c7d772d57d90
parent41922f1a6d153e4754bde2ef3a3662d578dfdc69
[Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Summary:
This has just bit me, so i though it would be nice to avoid that next time :)
Motivational case:
  https://godbolt.org/g/cq9UNk
Basically, it's likely to happen if you don't like shadowing issues,
and use `-Wshadow` and friends. And it won't be diagnosed by clang.

The reason is, these self-assign diagnostics only work for builtin assignment
operators. Which makes sense, one could have a very special operator=,
that does something unusual in case of self-assignment,
so it may make sense to not warn on that.

But while it may be intentional in some cases, it may be a bug in other cases,
so it would be really great to have some diagnostic about it...

Reviewers: aaron.ballman, rsmith, rtrieu, nikola, rjmccall, dblaikie

Reviewed By: rjmccall

Subscribers: EricWF, lebedev.ri, thakis, Quuxplusone, cfe-commits

Differential Revision: https://reviews.llvm.org/D44883

llvm-svn: 329493
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaExpr.cpp
clang/test/SemaCXX/member-init.cpp
clang/test/SemaCXX/warn-self-assign-builtin.cpp [new file with mode: 0644]
clang/test/SemaCXX/warn-self-assign-field-builtin.cpp [new file with mode: 0644]
clang/test/SemaCXX/warn-self-assign-field-overloaded.cpp [new file with mode: 0644]
clang/test/SemaCXX/warn-self-assign-overloaded.cpp [new file with mode: 0644]
clang/test/SemaCXX/warn-self-assign.cpp [deleted file]