net: bpf: arm64: fix module memory leak when JIT image build fails
authorDaniel Borkmann <dborkman@redhat.com>
Thu, 11 Sep 2014 09:36:48 +0000 (10:36 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 12 Sep 2014 15:33:14 +0000 (16:33 +0100)
commit60ef0494f197d4705b17132ee7d496283b5604b3
tree71351c6dbc12734b66b6239187928c8c4664b475
parentc2eb6b6139183af632a5be8f7c33006d7b03702d
net: bpf: arm64: fix module memory leak when JIT image build fails

On ARM64, when the BPF JIT compiler fills the JIT image body with
opcodes during translation of eBPF into ARM64 opcodes, we may fail
for several reasons during that phase: one being that we jump to
the notyet label for not yet supported eBPF instructions such as
BPF_ST. In that case we only free offsets, but not the actual
allocated target image where opcodes are being stored. Fix it by
calling module_free() on dismantle time in case of errors.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Zi Shen Lim <zlim.lnx@gmail.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/net/bpf_jit_comp.c