drm/i915: Factor out a helper for handling atomic modeset locks/state
authorImre Deak <imre.deak@intel.com>
Wed, 10 May 2023 10:31:29 +0000 (13:31 +0300)
committerImre Deak <imre.deak@intel.com>
Tue, 16 May 2023 13:53:49 +0000 (16:53 +0300)
commit60ded7cc86f363161e37dc41c548b2ab3e1af5ce
treebf5b263351724bd75ed79851a2afab08057eb52c
parent7e4460c34b011ae15a898256ad0682e3f34a94d1
drm/i915: Factor out a helper for handling atomic modeset locks/state

This patch simplifying the handling of modeset locks and atomic state
for an atomic commit is based on

https://lore.kernel.org/all/20210715184954.7794-2-ville.syrjala@linux.intel.com/

adding the helper to i915. I find this approach preferrable than
open-coding the corresponding steps (fixed for me an atomic
state reset during a DEADLK retry, which I missed in the open-coded
version) and also better than the existing
DRM_MODESET_LOCK_ALL_BEGIN/END macros for the reasons described in the
above original patchset.

This change takes the helper into use only for atomic commits during DDI
hotplug handling, as a preparation for a follow-up patch adding a
similar commit started from the same spot. Other places doing a
driver-internal atomic commit is to be converted by a follow-up
patchset.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230510103131.1618266-13-imre.deak@intel.com
drivers/gpu/drm/i915/Makefile
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/display/intel_modeset_lock.c [new file with mode: 0644]
drivers/gpu/drm/i915/display/intel_modeset_lock.h [new file with mode: 0644]