ASoC: cs35l56: Move DSP part string generation so that it is done only once
authorSimon Trimmer <simont@opensource.cirrus.com>
Thu, 18 May 2023 15:02:48 +0000 (16:02 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 19 May 2023 02:32:11 +0000 (11:32 +0900)
commit608f1b0dbddec6b2fd766c10bcce2b651995e936
tree22e825c4db0fdbdd7b10a8f5a8181cc671a99b1f
parentf1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6
ASoC: cs35l56: Move DSP part string generation so that it is done only once

Each time we go through dsp_work() it does a devm_kasprintf() to
allocate memory to hold the part name string. It's not strictly a memory
leak because devm will free it all if the driver is removed. But we keep
allocating more and more memory to hold the same string.

Move the allocation so that it is performed after the version and
secured state information is gathered and handle allocation errors.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/Message-Id:
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56.c