media: i2c: ccs: Check rules is non-NULL
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sat, 29 Jul 2023 18:59:25 +0000 (20:59 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 14 Aug 2023 18:27:58 +0000 (20:27 +0200)
commit607bcc4213d998d051541d8f10b5bbb7d546c0be
tree31508e8449fdbed3938984daad7b011e0021feeb
parentda57d1201eff8cc0bfce6cf16b3e5e9d47c02af1
media: i2c: ccs: Check rules is non-NULL

Fix the following smatch warning:

drivers/media/i2c/ccs/ccs-data.c:524 ccs_data_parse_rules() warn: address
of NULL pointer 'rules'

The CCS static data rule parser does not check an if rule has been
obtained before checking for other rule types (which depend on the if
rule). In practice this means parsing invalid CCS static data could lead
to dereferencing a NULL pointer.

Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Fixes: a6b396f410b1 ("media: ccs: Add CCS static data parser library")
Cc: stable@vger.kernel.org # for 5.11 and up
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ccs/ccs-data.c