soundwire: fix port_ready[] dynamic allocation in mipi_disco
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 31 Aug 2020 13:43:18 +0000 (21:43 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 3 Sep 2020 10:32:29 +0000 (16:02 +0530)
commit6073755886a463a7a7aecdd0abb32a1d38bdb7e6
treeb432fa9a3a5c2e787a3c2831062c07843d1aedde
parent63642595a78da42f841fabcc3f309f4c1362dc40
soundwire: fix port_ready[] dynamic allocation in mipi_disco

The existing code allocates memory for the total number of ports.
This only works if the ports are contiguous, but will break if e.g. a
Devices uses port0, 1, and 14. The port_ready[] array would contain 3
elements, which would lead to an out-of-bounds access. Conversely in
other cases, the wrong port index would be used leading to timeouts on
prepare.

This can be fixed by allocating for the worst-case of 15
ports (DP0..DP14). In addition since the number is now fixed, we can
use an array instead of a dynamic allocation.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20200831134318.11443-4-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/mipi_disco.c
drivers/soundwire/slave.c
include/linux/soundwire/sdw.h