don't assume that pa_asyncq_new() always succeeds
authorTanu Kaskinen <tanuk@iki.fi>
Tue, 13 Sep 2016 15:43:38 +0000 (18:43 +0300)
committerTanu Kaskinen <tanuk@iki.fi>
Mon, 19 Dec 2016 23:19:06 +0000 (01:19 +0200)
commit60695e3d84c98e4153edd5dda9dbf1dd7fde0de0
treee52b7afffdc91dff9b035383951cd87a35b772c4
parent3e52972c610f0609c11e592c761379ea6ab8803f
don't assume that pa_asyncq_new() always succeeds

Bug 96741 shows a case where an assertion is hit, because
pa_asyncq_new() failed due to running out of file descriptors.
pa_asyncq_new() is used in only one place (not counting the call in
asyncq-test): pa_asyncmsgq_new(). Now pa_asyncmsgq_new() can fail too,
which requires error handling in many places. One of those places is
pa_thread_mq_init(), which can now fail too, and that needs additional
error handling in many more places. Luckily there weren't any places
where adding better error handling wouldn't have been easy, so there are
many changes in this patch, but they are not complicated.

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=96741
27 files changed:
src/modules/alsa/alsa-sink.c
src/modules/alsa/alsa-source.c
src/modules/bluetooth/module-bluez4-device.c
src/modules/bluetooth/module-bluez5-device.c
src/modules/echo-cancel/module-echo-cancel.c
src/modules/jack/module-jack-sink.c
src/modules/jack/module-jack-source.c
src/modules/macosx/module-coreaudio-device.c
src/modules/module-combine-sink.c
src/modules/module-esound-sink.c
src/modules/module-loopback.c
src/modules/module-null-sink.c
src/modules/module-null-source.c
src/modules/module-pipe-sink.c
src/modules/module-pipe-source.c
src/modules/module-sine-source.c
src/modules/module-solaris.c
src/modules/module-tunnel-sink-new.c
src/modules/module-tunnel-source-new.c
src/modules/module-tunnel.c
src/modules/module-waveout.c
src/modules/module-zeroconf-publish.c
src/modules/oss/module-oss.c
src/modules/raop/module-raop-sink.c
src/pulsecore/asyncmsgq.c
src/pulsecore/thread-mq.c
src/pulsecore/thread-mq.h