staging: greybus: uart: replace driver line-coding struct
authorJohan Hovold <johan@kernel.org>
Thu, 14 May 2020 07:05:48 +0000 (09:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 May 2020 13:47:31 +0000 (15:47 +0200)
commit6064aeefa88c7c1bbb44737db55c5ff83f47718f
tree0aac3beeaefd4d4643c9706d79ea0173b29bc8b1
parentb50220c136c0a080230438562057a10880a0a123
staging: greybus: uart: replace driver line-coding struct

Drop the driver version of the line-coding request and use the protocol
definition directly as was originally intended instead.

This specifically avoids having the two versions of what is supposed to
be the same struct ever getting out of sync.

Note that this has in fact already happened once when the protocol
definition had its implicit padding removed while the driver struct
wasn't updated. The fact that we used the size of the then larger driver
struct when memcpying its content to the stack didn't exactly make
things better. A later addition of a flow-control field incidentally
made the structures match again.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20200514070548.4423-1-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/uart.c