playbin2: fix subtitle only seeks when switching to external subs
authorThiago Santos <thiago.sousa.santos@collabora.com>
Tue, 15 May 2012 15:56:13 +0000 (12:56 -0300)
committerThiago Santos <thiago.sousa.santos@collabora.com>
Wed, 6 Jun 2012 19:31:08 +0000 (16:31 -0300)
commit605d5c110cf1cbd53549a596737df1cde8b88472
tree772ccc3c5e633f0dc3494f8f4cebdbfe487511ff
parentbd5cfff9de4afc31a139e242efbc53bfe3982373
playbin2: fix subtitle only seeks when switching to external subs

Sending a non-flushing seek might not be enough for switching
to an external sub that has already been used because the flushes
are needed to reset the state of its decodebin's queue.

For example, if the subtitle is short enough, the queue might get
and EOS and keep its 'unexpected' return state. If the user switches
to another subtitle and back to the external one, the buffers
won't get past the queue.

This patch fixes this by adding the flush flag to the seek and
preventing that this flush leaves the suburidecodebin.

https://bugzilla.gnome.org/show_bug.cgi?id=638168

Conflicts:

gst/playback/gstplaybin2.c
gst/playback/gstplaybin2.c