gpio: dwapb: fix NULL pointer dereference at dwapb_gpio_suspend()
authorLuo Jiaxing <luojiaxing@huawei.com>
Fri, 27 Nov 2020 08:50:02 +0000 (16:50 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Wed, 2 Dec 2020 09:40:54 +0000 (10:40 +0100)
commit60593df667e087b009ee0fc20d92e9c4c096a9b5
treea1b4ba5bc78c49431c24331be686c461116c9394
parent0ac22098de6f9fd460ac1b1cbf6dbd324312161c
gpio: dwapb: fix NULL pointer dereference at dwapb_gpio_suspend()

Following Calltrace is found when running echo freeze > /sys/power/state.

[  272.755506] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010
[  272.755585] Call trace:
[  272.755587]  dwapb_gpio_suspend+0x18/0x318
[  272.755588]  pm_generic_suspend+0x2c/0x48
[  272.755595]  acpi_subsys_suspend+0x60/0x70
[  272.755599]  dpm_run_callback.isra.18+0x40/0xe0
[  272.755601]  __device_suspend+0xf4/0x360

The reason is platform_set_drvdata() is deleted, and dwapb_gpio_suspend()
get *gpio by dev_get_drvdata().

Fixes: feeaefd378ca ("gpio: dwapb: Use resource managed GPIO-chip add data method")
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-dwapb.c