Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed
authorNiels Dossche <dossche.niels@gmail.com>
Wed, 16 Mar 2022 15:33:50 +0000 (16:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:41 +0000 (14:23 +0200)
commit60283d3ad3955e68d91c132ff37d145a20261391
tree07f2c4979c9ab78060e2bbd3d4dbc7347a27b41b
parent7235485433d290367d60ae22fcdfc565e61d42ab
Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed

[ Upstream commit 9fa6b4cda3b414e990f008f45f9bcecbcb54d4d1 ]

hci_le_conn_failed function's documentation says that the caller must
hold hdev->lock. The only callsite that does not hold that lock is
hci_le_conn_failed. The other 3 callsites hold the hdev->lock very
locally. The solution is to hold the lock during the call to
hci_le_conn_failed.

Fixes: 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()")
Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/bluetooth/hci_conn.c