kill do_each_thread()
authorOleg Nesterov <oleg@redhat.com>
Thu, 17 Aug 2023 16:37:08 +0000 (18:37 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 21 Aug 2023 20:46:25 +0000 (13:46 -0700)
commit5ffd2c37cb7a53d52099e5ed1fd7ccbc9e358791
treefef673a9670941e2854fbf2997b0422ebc5a9f34
parentcdaac8e7e5a059f9b5e816cda257f08d0abffacd
kill do_each_thread()

Eric has pointed out that we still have 3 users of do_each_thread().
Change them to use for_each_process_thread() and kill this helper.

There is a subtle change, after do_each_thread/while_each_thread g == t ==
&init_task, while after for_each_process_thread() they both point to
nowhere, but this doesn't matter.

> Why is for_each_process_thread() better than do_each_thread()?

Say, for_each_process_thread() is rcu safe, do_each_thread() is not.

And certainly

for_each_process_thread(p, t) {
do_something(p, t);
}

looks better than

do_each_thread(p, t) {
do_something(p, t);
} while_each_thread(p, t);

And again, there are only 3 users of this awkward helper left.  It should
have been killed years ago and in fact I thought it had already been
killed.  It uses while_each_thread() which needs some changes.

Link: https://lkml.kernel.org/r/20230817163708.GA8248@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: "Christian Brauner (Microsoft)" <brauner@kernel.org>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Jiri Slaby <jirislaby@kernel.org> # tty/serial
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/ia64/kernel/mca.c
drivers/tty/tty_io.c
fs/fs_struct.c
include/linux/sched/signal.h