net: apple: bmac: don't call dev_kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 8 Dec 2022 13:37:35 +0000 (21:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Dec 2022 09:53:10 +0000 (09:53 +0000)
commit5fe02e046e6422c4adfdbc50206ec7186077da24
tree3804c99375eb7ca1163725841b56997580f49119
parent3dfe3486c1cd4f82b466b7d307f23777137b8acc
net: apple: bmac: don't call dev_kfree_skb() under spin_lock_irqsave()

It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.

It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.

In this case, dev_kfree_skb() is called in bmac_tx_timeout() to drop
the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/apple/bmac.c