ALSA: usb-audio: Fix init call orders for UAC1
authorTakashi Iwai <tiwai@suse.de>
Mon, 21 Aug 2023 11:18:57 +0000 (13:18 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 21 Aug 2023 14:20:25 +0000 (16:20 +0200)
commit5fadc941d07530d681f3b7ec91e56d8445bc3825
tree6e0747c98876330a3621a699a5d5b7ea5ae3f89e
parentf286620b5dc974fe281d8feed6e228fd2f39d013
ALSA: usb-audio: Fix init call orders for UAC1

There have been reports of USB-audio driver spewing errors at the
probe time on a few devices like Jabra and Logitech.  The suggested
fix there couldn't be applied as is, unfortunately, because it'll
likely break other devices.

But, the patch suggested an interesting point: looking at the current
init code in stream.c, one may notice that it does initialize
differently from the device setup in endpoint.c.  Namely, for UAC1, we
should call snd_usb_init_pitch() and snd_usb_init_sample_rate() after
setting the interface, while the init sequence at parsing calls them
before setting the interface blindly.

This patch changes the init sequence at parsing for UAC1 (and other
devices that need a similar behavior) to be aligned with the rest of
the code, setting the interface at first.  And, this fixes the
long-standing problems on a few UAC1 devices like Jabra / Logitech,
as reported, too.

Reported-and-tested-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Closes: https://lore.kernel.org/r/202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230821111857.28926-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/stream.c