USB: serial: fix return value for unsupported ioctls
authorJohan Hovold <johan@kernel.org>
Wed, 7 Apr 2021 10:39:20 +0000 (12:39 +0200)
committerJohan Hovold <johan@kernel.org>
Thu, 8 Apr 2021 07:46:01 +0000 (09:46 +0200)
commit5f92aee93a68c3f3b13dc28a7e220adbdc3433b0
treeb4ca87e4f861327bbde22d13aeaa848b8952b6a6
parent6f9f8aeab7fd5cc9a54096f5053fa3c79154756e
USB: serial: fix return value for unsupported ioctls

Drivers should return -ENOTTY ("Inappropriate I/O control operation")
when an ioctl isn't supported, while -EINVAL is used for invalid
arguments.

Fix up the TIOCMGET, TIOCMSET and TIOCGICOUNT helpers which returned
-EINVAL when a USB serial driver did not implement the corresponding
methods.

Note that the TIOCMGET and TIOCMSET helpers predate git and do not get a
corresponding Fixes tag below.

Fixes: d281da7ff6f7 ("tty: Make tiocgicount a handler")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/usb-serial.c