qpa: Remove QPlatformDialogHelper::deleteNativeDialog()
authorBradley T. Hughes <bradley.hughes@nokia.com>
Wed, 9 May 2012 11:55:25 +0000 (13:55 +0200)
committerQt by Nokia <qt-info@nokia.com>
Thu, 10 May 2012 04:56:20 +0000 (06:56 +0200)
commit5f43422ddf38e48f56b2ef39ee19bec2cb430ac4
treeb8be9f5168345b2ff366881e0bc31f6f39fc4d8d
parentd223b30c42a9a8d42a8dd35b2d93615e646b4f1e
qpa: Remove QPlatformDialogHelper::deleteNativeDialog()

This function isn't really needed. The QDialogPrivate destructor deletes
the platform helper, so the QDialog destructor does not need to do it.
Subclasses of QPlatformDialogHelper are now responsible for deleting any
native resources they create.

The one place in QFileDialog that needs to recreate the native dialog
can simply recreate the helper. QDialogPrivate::deleteNativeDialog() now
becomes QDialogPrivate::deletePlatformHelper(), which resets all state
to allow the platform helper to be recreated.

Change-Id: I58adfe8801e02e63b3cb4a9a3a0b8cb5b3c7b161
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 files changed:
src/gui/kernel/qplatformdialoghelper.h
src/plugins/platforms/cocoa/qcocoacolordialoghelper.h
src/plugins/platforms/cocoa/qcocoacolordialoghelper.mm
src/plugins/platforms/cocoa/qcocoafiledialoghelper.h
src/plugins/platforms/cocoa/qcocoafiledialoghelper.mm
src/plugins/platforms/cocoa/qcocoafontdialoghelper.h
src/plugins/platforms/cocoa/qcocoafontdialoghelper.mm
src/plugins/platforms/windows/qwindowsdialoghelpers.cpp
src/plugins/platforms/windows/qwindowsdialoghelpers.h
src/widgets/dialogs/qdialog.cpp
src/widgets/dialogs/qdialog_p.h
src/widgets/dialogs/qfiledialog.cpp