platform/x86: thinkpad_acpi: initialize tp_nvram_state variable
authorTom Rix <trix@redhat.com>
Sun, 13 Sep 2020 19:02:03 +0000 (12:02 -0700)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 24 Sep 2020 11:04:52 +0000 (14:04 +0300)
commit5f38b06db8af3ed6c2fc1b427504ca56fae2eacc
tree77d4e9e721b0fba6f3c97ae355f1e93ad5f74921
parentd823346876a970522ff9e4d2b323c9b734dcc4de
platform/x86: thinkpad_acpi: initialize tp_nvram_state variable

clang static analysis flags this represenative problem
thinkpad_acpi.c:2523:7: warning: Branch condition evaluates
  to a garbage value
                if (!oldn->mute ||
                    ^~~~~~~~~~~

In hotkey_kthread() mute is conditionally set by hotkey_read_nvram()
but unconditionally checked by hotkey_compare_and_issue_event().
So the tp_nvram_state variable s[2] needs to be initialized.

Fixes: 01e88f25985d ("ACPI: thinkpad-acpi: add CMOS NVRAM polling for hot keys (v9)")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: mark gross <mgross@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c