Fix a couple issues with Vector128.Get/WithElement (#52985)
authorTanner Gooding <tagoo@outlook.com>
Tue, 25 May 2021 23:07:52 +0000 (16:07 -0700)
committerGitHub <noreply@github.com>
Tue, 25 May 2021 23:07:52 +0000 (23:07 +0000)
commit5f15498d937653986821d636c04cd03c58d4bb4c
tree19cfd34ef59d4767c814f8421a39d09fedf75a65
parent959c3275e80a41d6485ec4f4dec7aa477ee46ed6
Fix a couple issues with Vector128.Get/WithElement (#52985)

* Fix an issue with Vector128.WithElement around unused nodes for pre SSE4.1

* Fixing the expected exception for a structreturn test

* Ensure we check if the baseline SIMD ISAs are supported in morph

* Ensure TYP_SIMD12 LclVar can be cloned in lowering

* Fixing up the non SSE41 path for WithElement

* Applying formatting patch

* Ensure ReplaceWithLclVar lowers the created LclVar and assignment

* Don't check the JitLog for compiled methods when the baseline ISAs aren't supported

* Address PR feedback

* Responding to more PR feedback

* Applying formatting patch

* Fixing the more PR review feedback
12 files changed:
src/coreclr/jit/compiler.h
src/coreclr/jit/gentree.cpp
src/coreclr/jit/lir.cpp
src/coreclr/jit/lir.h
src/coreclr/jit/lower.h
src/coreclr/jit/lowerxarch.cpp
src/coreclr/jit/morph.cpp
src/coreclr/jit/simd.cpp
src/coreclr/jit/simdashwintrinsic.cpp
src/tests/JIT/Directed/StructABI/structreturn.cs
src/tests/JIT/SIMD/VectorArray.cs
src/tests/JIT/SIMD/VectorGet.cs