HID: hyperv: avoid struct memcpy overrun warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 5 Jul 2023 14:02:24 +0000 (16:02 +0200)
committerBenjamin Tissoires <bentiss@kernel.org>
Sun, 9 Jul 2023 10:47:37 +0000 (12:47 +0200)
commit5f151364b1da6bd217632fd4ee8cc24eaf66a497
treedecf1f0c4242d025fc72107ab43be7309963df02
parentf9abdcc617dad5f14bbc2ebe96ee99f3e6de0c4e
HID: hyperv: avoid struct memcpy overrun warning

A previous patch addressed the fortified memcpy warning for most
builds, but I still see this one with gcc-9:

In file included from include/linux/string.h:254,
                 from drivers/hid/hid-hyperv.c:8:
In function 'fortify_memcpy_chk',
    inlined from 'mousevsc_on_receive' at drivers/hid/hid-hyperv.c:272:3:
include/linux/fortify-string.h:583:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
  583 |    __write_overflow_field(p_size_field, size);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

My guess is that the WARN_ON() itself is what confuses gcc, so it no
longer sees that there is a correct range check. Rework the code in a
way that helps readability and avoids the warning.

Fixes: 542f25a94471 ("HID: hyperv: Replace one-element array with flexible-array member")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20230705140242.844167-1-arnd@kernel.org
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-hyperv.c