Remove Widget::beforeMouseDown and Widget::afterMouseDown
authorandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Sep 2011 20:37:34 +0000 (20:37 +0000)
committerandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Sep 2011 20:37:34 +0000 (20:37 +0000)
commit5f0ce69a441d4e0bb90c2085f2c1d8a2896fd37a
tree3a9819ad2cbbd30ada86bc19f8a178388e383ee8
parent2d0fed9ac7942e721a53e07cefe6ebe523aaf7b5
Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570

Reviewed by Darin Adler.

These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.

This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):

* rendering/RenderWidget.cpp:
Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/page/mac/EventHandlerMac.mm
Source/WebCore/platform/Widget.h
Source/WebCore/platform/mac/WidgetMac.mm
Source/WebCore/rendering/RenderWidget.cpp