net/sched: avoid double free on matchall reoffload
authorPieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Wed, 8 May 2019 22:56:07 +0000 (15:56 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 May 2019 23:34:58 +0000 (16:34 -0700)
commit5f05836831f6142081e216f27e1ae8f4b26d3585
tree96b9705380233c6d606017466de3353157c87328
parent1e966763e256393965c78aa09b89027fac6b8bf1
net/sched: avoid double free on matchall reoffload

Avoid freeing cls_mall.rule twice when failing to setup flow_action
offload used in the hardware intermediate representation. This is
achieved by returning 0 when the setup fails but the skip software
flag has not been set.

Fixes: f00cbf196814 ("net/sched: use the hardware intermediate representation for matchall")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_matchall.c