Fix-7167-UWP-ListViewRenderer-ScrollToTop-when-NotifyCollectionChangedAction.Reset...
authorBrayan Khosravian <35541212+BrayanKhosravian@users.noreply.github.com>
Thu, 28 Nov 2019 08:12:23 +0000 (09:12 +0100)
committerShane Neuville <shneuvil@microsoft.com>
Thu, 28 Nov 2019 08:12:22 +0000 (01:12 -0700)
commit5ee7b000b7c5242c31ab9a0a9684b5ab854e402c
tree940ab5775170f19ce59c289e3da10f95c900fc33
parent67f7eda2cc705317d191dcad82e6dd9d09370a09
Fix-7167-UWP-ListViewRenderer-ScrollToTop-when-NotifyCollectionChangedAction.Reset (#7279)

* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.

* - changed controlgalery.projitems manually after cherrypick

* - made testcase uitestable

* - fixed uitesting exception

* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)

* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.

* - changed controlgalery.projitems manually after cherrypick

* - made testcase uitestable

* - fixed uitesting exception

* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)

* - wrote uitest, formetted

* - updated comments

* - uitest are only being executed for UWP

* - removed comments (PR feedback)
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7167.xaml [new file with mode: 0644]
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7167.xaml.cs [new file with mode: 0644]
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Xamarin.Forms.Platform.UAP/ListViewRenderer.cs