locking/ww_mutex: Report recursive ww_mutex locking early
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 26 May 2016 20:08:17 +0000 (21:08 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 17 Jun 2016 19:37:42 +0000 (15:37 -0400)
commit5ec6f21ee5c6d2207708a8469771efbde823488f
tree0fc4d978c211675d13782dc2b9e5216d3ab52859
parentc0410f18e2b4f62090b04743f0d5d8e672335225
locking/ww_mutex: Report recursive ww_mutex locking early

[ Upstream commit 0422e83d84ae24b933e4b0d4c1e0f0b4ae8a0a3b ]

Recursive locking for ww_mutexes was originally conceived as an
exception. However, it is heavily used by the DRM atomic modesetting
code. Currently, the recursive deadlock is checked after we have queued
up for a busy-spin and as we never release the lock, we spin until
kicked, whereupon the deadlock is discovered and reported.

A simple solution for the now common problem is to move the recursive
deadlock discovery to the first action when taking the ww_mutex.

Suggested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1464293297-19777-1-git-send-email-chris@chris-wilson.co.uk
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
kernel/locking/mutex.c