Fix warnings found with CA1861 Avoid constant arrays as arguments (#86229)
authorBuyaa Namnan <bunamnan@microsoft.com>
Wed, 31 May 2023 21:01:01 +0000 (14:01 -0700)
committerGitHub <noreply@github.com>
Wed, 31 May 2023 21:01:01 +0000 (14:01 -0700)
commit5e67657e20665c32c2bd5c4ac1c8b1af78c9677e
tree81bcd71d8cb216857577a3c55f9cd70efdcc1472
parented2634403de655ba68230ad531e2b7cb1c21b87f
Fix warnings found with CA1861 Avoid constant arrays as arguments (#86229)

* Fix warnings found with CA1861

* Update src/coreclr/tools/aot/ILCompiler/Program.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Remove supression from static field

* Revert using string.Split(char)

* Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationILGen.cs

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
48 files changed:
eng/CodeAnalysis.src.globalconfig
eng/CodeAnalysis.test.globalconfig
src/coreclr/tools/aot/ILCompiler/ILCompilerRootCommand.cs
src/coreclr/tools/aot/ILCompiler/Program.cs
src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/IDispatchMetaObject.cs
src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/VariantArray.cs
src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/ExpressionBinder.cs
src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextPaths.cs
src/libraries/Microsoft.Extensions.Logging.EventSource/src/LoggingEventSource.cs
src/libraries/System.Data.OleDb/src/OleDbCommandBuilder.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionInternal.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionStringBuilder.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx_LoadStore.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/SDSUtils.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Group.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/SAM/SAMUtils.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ADAMInstance.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectoryInterSiteTransport.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySite.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySiteLink.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySiteLinkBridge.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySubnet.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/DirectoryServer.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ReplicationConnection.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/Utils.cs
src/libraries/System.Net.Requests/src/System/Net/FtpControlStream.cs
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlSchemaValidator.cs
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationILGen.cs
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReaderILGen.cs
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/OidLookup.cs
src/libraries/System.Speech/src/Internal/ObjectToken/RegistryDataKey.cs
src/libraries/System.Speech/src/Internal/SrgsCompiler/AppDomainGrammarProxy.cs
src/libraries/System.Speech/src/Recognition/Grammar.cs
src/libraries/System.Speech/src/Recognition/RecognizerBase.cs
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
src/libraries/System.Text.RegularExpressions/gen/UpgradeToGeneratedRegexCodeFixer.cs
src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeParameterInfo.cs
src/mono/wasm/host/BrowserHost.cs
src/mono/wasm/host/Options.cs
src/mono/wasm/symbolicator/WasmSymbolicator.cs
src/tasks/AotCompilerTask/MonoAOTCompiler.cs
src/tasks/Crossgen2Tasks/RunReadyToRunCompiler.cs
src/tasks/WasmAppBuilder/EmccCompile.cs
src/tools/illink/src/linker/Linker/Driver.cs