crypto: dh - Don't permit 'key' or 'g' size longer than 'p'
authorEric Biggers <ebiggers@google.com>
Mon, 6 Nov 2017 02:30:46 +0000 (18:30 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Nov 2017 08:49:21 +0000 (09:49 +0100)
commit5e56be0e260cc367d2eb1823a9b476d018d80152
treec8b9d5e4b5ea30de8d8b1cfe373baacfeaab6be1
parent716b9ea8c6b07e293eb4af7cd68cbbb6c9490120
crypto: dh - Don't permit 'key' or 'g' size longer than 'p'

commit ccd9888f14a8019c0bbdeeae758aba1f58693712 upstream.

The "qat-dh" DH implementation assumes that 'key' and 'g' can be copied
into a buffer with size 'p_size'.  However it was never checked that
that was actually the case, which most likely allowed users to cause a
buffer underflow via KEYCTL_DH_COMPUTE.

Fix this by updating crypto_dh_decode_key() to verify this precondition
for all DH implementations.

Fixes: c9839143ebbf ("crypto: qat - Add DH support")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/dh_helper.c