ext4: unregister sysfs path before destroying jbd2 journal
authorRitesh Harjani <riteshh@linux.ibm.com>
Wed, 18 Mar 2020 06:13:01 +0000 (11:43 +0530)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 26 Mar 2020 14:52:49 +0000 (10:52 -0400)
commit5e47868fb94b63c7068dcfd2469d99fba06bae9d
treed4fb41eae543918573f41d67885cef56f83e6b34
parentf1eec3b0d0a849996ebee733b053efa71803dad5
ext4: unregister sysfs path before destroying jbd2 journal

Call ext4_unregister_sysfs(), before destroying jbd2 journal,
since below might cause, NULL pointer dereference issue.
This got reported with LTP tests.

ext4_put_super()  cat /sys/fs/ext4/loop2/journal_task
|  ext4_attr_show();
ext4_jbd2_journal_destroy();   |
     |  journal_task_show()
|  |
|  task_pid_vnr(NULL);
sbi->s_journal = NULL;

Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200318061301.4320-1-riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c