[ASTUnit] Fix a regression in cached completions
authorIlya Biryukov <ibiryukov@google.com>
Thu, 18 Jul 2019 15:21:34 +0000 (15:21 +0000)
committerIlya Biryukov <ibiryukov@google.com>
Thu, 18 Jul 2019 15:21:34 +0000 (15:21 +0000)
commit5de0c85e88bea9a8cf312c93d9276f13d68af476
tree0efaa54c3eeda90d6bb2af845fbf65bcf0118dae
parenta5359b1b0754ff70b0a36917a5e61625c951b408
[ASTUnit] Fix a regression in cached completions

Summary:
After r345152 cached completions started adding namespaces after
nested name specifiers, e.g. in `some_name::^`

The CCC_Symbol indicates the completed item cannot be a namespace (it is
described as being "a type, a function or a variable" in the comments).

Therefore, 'nested specifier' completions should only be added from cache
when the context is CCC_SymbolOrNewName (which roughly seems to indicate
that a nested name specifier is allowed).

Fixes https://bugs.llvm.org/show_bug.cgi?id=42646

Reviewers: kadircet, sammccall

Reviewed By: kadircet, sammccall

Subscribers: arphaman, nik, sammccall, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64918

llvm-svn: 366448
clang/lib/Frontend/ASTUnit.cpp
clang/test/Index/complete-qualified-cached.cpp [new file with mode: 0644]