net: Catch invalid index in XPS mapping
authorNick Child <nnac123@linux.ibm.com>
Tue, 21 Mar 2023 15:07:24 +0000 (10:07 -0500)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Mar 2023 05:38:25 +0000 (22:38 -0700)
commit5dd0dfd55baec0742ba8f5625a0dd064aca7db16
tree33fafd31d5e13de152d04ab17622909903a610e8
parent5da12895dad53ffb159b7fa9f33b198a051b7b44
net: Catch invalid index in XPS mapping

When setting the XPS value of a TX queue, warn the user once if the
index of the queue is greater than the number of allocated TX queues.

Previously, this scenario went uncaught. In the best case, it resulted
in unnecessary allocations. In the worst case, it resulted in
out-of-bounds memory references through calls to `netdev_get_tx_queue(
dev, index)`. Therefore, it is important to inform the user but not
worth returning an error and risk downing the netdevice.

Signed-off-by: Nick Child <nnac123@linux.ibm.com>
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
Link: https://lore.kernel.org/r/20230321150725.127229-1-nnac123@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c